New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix #472

Merged

inokawa merged 1 commit into inokawa:main from rahulyadav5524:memo-fix

Jul 18, 2024

Merged

Minor fix #472

Minor fix

Annotations

10 warnings

src/react/VGrid.tsx#L319

React Hook useImperativeHandle has missing dependencies: 'hStore', 'scroller._scrollBy', 'scroller._scrollTo', 'scroller._scrollToIndex', and 'vStore'. Either include them or remove the dependency array

src/react/Virtualizer.tsx#L315

React Hook useEffect has a missing dependency: 'onRangeChangeProp'. Either include it or remove the dependency array. If 'onRangeChangeProp' changes too often, find the parent component that defines it and wrap that definition in useCallback

src/react/Virtualizer.tsx#L339

React Hook useImperativeHandle has missing dependencies: 'scroller._scrollBy', 'scroller._scrollTo', 'scroller._scrollToIndex', and 'store'. Either include them or remove the dependency array

src/react/WindowVirtualizer.tsx#L219

src/react/WindowVirtualizer.tsx#L230

React Hook useImperativeHandle has a missing dependency: 'store'. Either include it or remove the dependency array

src/solid/ListItem.tsx#L32

The reactive variable 'props' should not be reassigned or altered directly

src/solid/ListItem.tsx#L32

The reactive variable 'props' should not be reassigned or altered directly

src/solid/RangedFor.tsx#L40

For proper analysis, a variable should be used to capture the result of this function call

src/solid/RangedFor.tsx#L53

For proper analysis, array destructuring should be used to capture the first result of this function call

src/solid/VList.tsx#L53

The reactive variable 'props' should be used within JSX, a tracked scope (like createEffect), or inside an event handler function, or else changes will be ignored

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Minor fix #472

Minor fix #472

Annotations

This job succeeded

Re-running jobs...