Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on entry cache #9

Conversation

gengliqi
Copy link

@gengliqi gengliqi commented Jan 18, 2021

Always turn on the entry cache to make the raft entry be got even when the write batch has not been written to raft db yet.

Because of these 3 reasons below, we can ensure the entry can be got after handling the raft ready

  1. the entries which have been written to raft db can be considered as persisted(ensured by the logic of async io)
  2. the entries which have been persisted can be applied(ensured by raft-rs)
  3. the entries which have been applied in entry cache can be removed(ensured by the logic of raft log gc)

Signed-off-by: gengliqi <gengliqiii@gmail.com>
@innerr innerr merged commit d79115b into innerr:raftstore-async-io-merge-region-io Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants