Added support to build sdist of V2 module. #8711
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderr
requested changes
Feb 6, 2025
jptrindade
approved these changes
Feb 10, 2025
tests/moduletool/test_build.py
Outdated
Comment on lines
144
to
145
| # member_path = pathlib.Path(tar.getnames()[0]) | ||
| # extract_dir = str(pathlib.Path(extract_dir).relative_to(member_path.parts[0])) |
There was a problem hiding this comment.
It seems I forgot to push my latest commits.
@jptrindade Could you elaborate on this? What do you want to change it to? An Enum? |
sanderr
requested changes
Feb 10, 2025
sanderr
approved these changes
Feb 10, 2025
|
Processing this pull request |
inmantaci
pushed a commit
that referenced
this pull request
Feb 11, 2025
# Description Added support to build sdist of V2 module. Part of #8111 - [x] Attached issue to pull request - [x] Changelog entry - [x] Type annotations are present - [x] Code is clear and sufficiently documented - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [x] Sufficient test cases (reproduces the bug/tests the requested feature) - [x] Correct, in line with design - [x] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] ~~If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)~~
|
Merged into branches master, iso8 in e9d13ab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support to build sdist of V2 module.
Part of #8111
If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)