Issue/927 add env settings #4603
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloLey
commented
Jul 28, 2022
src/inmanta/data/__init__.py
Outdated
|
|
||
| :param setting: the setting that should be added to the existing settings | ||
| """ | ||
| assert isinstance(setting, Setting) |
There was a problem hiding this comment.
I don't know if those checks are really needed or if something else should be checker
There was a problem hiding this comment.
Indeed. This is not really needed. If we violate this constraint, the type checker should warn us.
arnaudsjs
requested changes
Jul 29, 2022
src/inmanta/data/__init__.py
Outdated
|
|
||
| :param setting: the setting that should be added to the existing settings | ||
| """ | ||
| assert isinstance(setting, Setting) |
There was a problem hiding this comment.
Indeed. This is not really needed. If we violate this constraint, the type checker should warn us.
arnaudsjs
requested changes
Jul 29, 2022
arnaudsjs
requested changes
Jul 29, 2022
Co-authored-by: arnaudsjs <2684622+arnaudsjs@users.noreply.github.com>
Co-authored-by: arnaudsjs <2684622+arnaudsjs@users.noreply.github.com>
Co-authored-by: arnaudsjs <2684622+arnaudsjs@users.noreply.github.com>
Co-authored-by: arnaudsjs <2684622+arnaudsjs@users.noreply.github.com>
arnaudsjs
approved these changes
Aug 1, 2022
wouterdb
requested changes
Aug 1, 2022
There was a problem hiding this comment.
I think it would be good to test what happens when a setting exists in the database for which the definition no longer exists.
(e.g we start the server with all extensions disabled).
I would expect the api to not return any unknown settings, but just keep them in the database.
wouterdb
requested changes
Aug 4, 2022
|
|
||
| result = await client.get_setting(tid=environment, id="a new setting") | ||
| assert result.code == 404 | ||
| assert result.result["message"] == "Request or referenced resource does not exist" |
There was a problem hiding this comment.
Could you also verify it is not returned by a listing either and that if you register the option, it is returned by both?
wouterdb
approved these changes
Aug 4, 2022
|
Processing this pull request |
|
Pull request rejected by merge tool. The tests for this branch did not succeed. |
|
Processing this pull request |
inmantaci
pushed a commit
that referenced
this pull request
Aug 4, 2022
…inmanta-core (Issue inmanta/inmanta-lsm#927, PR #4603) # Description add the possibility to add extra settings to the env from outside of inmanta-core. # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [x] Attached issue to pull request - [x] Changelog entry - [x] Type annotations are present - [x] Code is clear and sufficiently documented - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [x] Sufficient test cases (reproduces the bug/tests the requested feature) - [x] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) # Reviewer Checklist: - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Code is clear and sufficiently documented - [ ] Correct, in line with design
|
Merged into branches master in 4e9aba8 |
inmantaci
pushed a commit
that referenced
this pull request
Aug 4, 2022
…inmanta-core (Issue inmanta/inmanta-lsm#927, PR #4603) # Description add the possibility to add extra settings to the env from outside of inmanta-core. # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [x] Attached issue to pull request - [x] Changelog entry - [x] Type annotations are present - [x] Code is clear and sufficiently documented - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [x] Sufficient test cases (reproduces the bug/tests the requested feature) - [x] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) # Reviewer Checklist: - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Code is clear and sufficiently documented - [ ] Correct, in line with design
|
Processing #4627. |
inmantaci
pushed a commit
that referenced
this pull request
Aug 4, 2022
…inmanta-core (Issue inmanta/inmanta-lsm#927, PR #4603) Pull request opened by the merge tool on behalf of #4603
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add the possibility to add extra settings to the env from outside of inmanta-core.
Self Check:
Strike through any lines that are not applicable (
~~line~~) then check the boxReviewer Checklist: