Skip to content

Commit

Permalink
Merge pull request #18 from inloop/swift5
Browse files Browse the repository at this point in the history
Swift 5 update
  • Loading branch information
jakubpetrik authored Apr 9, 2019
2 parents 5d4907f + 320548b commit df76875
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
# * https://www.objc.io/issues/6-build-tools/travis-ci/
# * https://github.com/supermarin/xcpretty#usage

osx_image: xcode10.1
osx_image: xcode10.2
language: swift
cache: cocoapods
script:
- pod lib lint
- set -o pipefail && xcodebuild -project UIViewController-DisplayChild.xcodeproj -scheme UIViewController-DisplayChild -sdk iphonesimulator12.1 ONLY_ACTIVE_ARCH=NO | xcpretty
- set -o pipefail && xcodebuild -project UIViewController-DisplayChild.xcodeproj -scheme UIViewController-DisplayChild -sdk iphonesimulator12.2 ONLY_ACTIVE_ARCH=NO | xcpretty
4 changes: 2 additions & 2 deletions UIViewController-DisplayChild.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'UIViewController-DisplayChild'
s.version = '2.1.0'
s.version = '2.2.0'
s.summary = 'UIViewController containment made easy'
s.description = <<-DESC
The problem: sometimes you need to embed a controller, but it might be embedded already. E.g. you have an empty view, and you do refresh only to get empty view again. If you do not check for its existence, you might end up creating a new instance unneccessarily. This can also have bad side effects when there is some heavier work in viewDidLoad for example.
Expand All @@ -13,7 +13,7 @@ The solution: transition to type, instead of an instance. If the instance does n
s.author = { 'INLOOPX' => 'info@inloopx.com' }
s.source = { :git => 'https://github.com/inloop/UIViewController-DisplayChild.git', :tag => s.version.to_s }
s.ios.deployment_target = '10.0'
s.swift_version = '4.2'
s.swift_version = '5'
s.source_files = 'UIViewController-DisplayChild/**/*'
s.exclude_files = 'UIViewController-DisplayChild/Info.plist'
end
6 changes: 3 additions & 3 deletions UIViewController-DisplayChild.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@
TargetAttributes = {
3B0791D82088D3DE00A39104 = {
CreatedOnToolsVersion = 9.3;
LastSwiftMigration = 0930;
LastSwiftMigration = 1020;
};
};
};
Expand Down Expand Up @@ -291,7 +291,7 @@
PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
SKIP_INSTALL = YES;
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
SWIFT_VERSION = 4.2;
SWIFT_VERSION = 5.0;
TARGETED_DEVICE_FAMILY = "1,2";
};
name = Debug;
Expand Down Expand Up @@ -319,7 +319,7 @@
PRODUCT_BUNDLE_IDENTIFIER = com.inloopx.Vito;
PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
SKIP_INSTALL = YES;
SWIFT_VERSION = 4.2;
SWIFT_VERSION = 5.0;
TARGETED_DEVICE_FAMILY = "1,2";
};
name = Release;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ public protocol Instantiable {
}

public extension UIViewController {
public typealias VoidClosure = () -> Void
typealias VoidClosure = () -> Void

static let embedTransitionAnimationDuration = 0.25

Expand Down

0 comments on commit df76875

Please sign in to comment.