Get the path for the deepest matching element #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We usually want to grab the path for the deepest (leaf) matching object in the tree; this is especially true in iOS 7 since Apple changed the accessibility hierarchy and inserted intermediate views or accessibility elements in between. Let’s modify `-rawAccessibilityPathToElement:favoringSubviews:` to search for the deepest matching object instead of return the first the method encounters.
ghost
assigned 
|
For reference, a case where Subliminal previously failed was in matching links within web views. |
|
Elegant fix. Looks good as soon as Travis finishes. |
wearhere
added a commit
that referenced
this pull request
Jan 29, 2014
Get the path for the deepest matching element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We usually want to grab the path for the deepest (leaf) matching object in the tree; this is especially true in iOS 7 since Apple changed the accessibility hierarchy and inserted intermediate views or accessibility elements in between.
Let’s modify
-rawAccessibilityPathToElement:favoringSubviews:to search for the deepest matching object instead of return the first the method encounters.