Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial step 2 - Uplift to latest ink! and Openbrush #14

Open
wants to merge 4 commits into
base: tutorial/mint-step2
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions contracts/shiden34/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,24 +1,17 @@
[package]
name = "shiden34"
version = "1.0.0"
version = "3.1.0"
authors = ["Astar builder"]
edition = "2021"

[dependencies]
ink = { version = "~4.0.0", default-features = false}

ink = { version = "4.2.1", default-features = false }
scale = { package = "parity-scale-codec", version = "3", default-features = false, features = ["derive"] }
scale-info = { version = "2.3", default-features = false, features = ["derive"], optional = true }

openbrush = { tag = "3.0.0", git = "https://github.com/727-Ventures/openbrush-contracts", default-features = false, features = ["psp34", "ownable"] }
scale-info = { version = "2.6", default-features = false, features = ["derive"], optional = true }
openbrush = { tag = "v4.0.0-beta", git = "https://github.com/Brushfam/openbrush-contracts", default-features = false, features = ["psp34", "ownable"] }

[lib]
name = "shiden34"
path = "lib.rs"
crate-type = [
# Used for normal contract Wasm blobs.
"cdylib",
]

[features]
default = ["std"]
Expand All @@ -29,4 +22,4 @@ std = [

"openbrush/std",
]
ink-as-dependency = []
ink-as-dependency = []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add new line

53 changes: 27 additions & 26 deletions contracts/shiden34/lib.rs
Original file line number Diff line number Diff line change
@@ -1,58 +1,59 @@
#![cfg_attr(not(feature = "std"), no_std)]
#![feature(min_specialization)]
#![cfg_attr(not(feature = "std"), no_std, no_main)]

#[openbrush::implementation(PSP34, PSP34Enumerable, PSP34Metadata, PSP34Mintable, Ownable)]
#[openbrush::contract]
pub mod shiden34 {
use openbrush::{
contracts::ownable::*,
contracts::psp34::extensions::{enumerable::*, metadata::*, mintable::*},
traits::{Storage, String},
};
use openbrush::traits::Storage;

#[ink(storage)]
#[derive(Default, Storage)]
pub struct Shiden34 {
#[storage_field]
psp34: psp34::Data<enumerable::Balances>,
psp34: psp34::Data,
#[storage_field]
ownable: ownable::Data,
#[storage_field]
metadata: metadata::Data,
#[storage_field]
enumerable: enumerable::Data,
}

impl PSP34 for Shiden34 {}
impl Ownable for Shiden34 {}
impl PSP34Mintable for Shiden34 {
#[ink(message)]
#[openbrush::modifiers(only_owner)]
fn mint(&mut self, account: AccountId, id: Id) -> Result<(), PSP34Error> {
self._mint_to(account, id)
}
#[overrider(PSP34Mintable)]
#[openbrush::modifiers(only_owner)]
fn mint(&mut self, account: AccountId, id: Id) -> Result<(), PSP34Error> {
psp34::InternalImpl::_mint_to(self, account, id)
}
Comment on lines +21 to 25
Copy link
Member

@Maar-io Maar-io Jul 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is not needed since we added mint() in the contract implementation.
However if OB can now support payable in the overriden function then mint is not needed in the contract implementation

impl PSP34Enumerable for Shiden34 {}
impl PSP34Metadata for Shiden34 {}

impl Shiden34 {
#[ink(constructor)]
pub fn new() -> Self {
let mut instance = Self::default();
instance._init_with_owner(instance.env().caller());
let collection_id = instance.collection_id();
instance._set_attribute(
let mut _instance = Self::default();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not use _ since the variable is used

ownable::Internal::_init_with_owner(&mut _instance, Self::env().caller());
psp34::Internal::_mint_to(&mut _instance, Self::env().caller(), Id::U8(1))
.expect("Can mint");
let collection_id = psp34::PSP34Impl::collection_id(&_instance);
metadata::Internal::_set_attribute(
&mut _instance,
collection_id.clone(),
String::from("name"),
String::from("Shiden34"),
);
instance._set_attribute(collection_id, String::from("symbol"), String::from("SH34"));
instance
metadata::Internal::_set_attribute(
&mut _instance,
collection_id,
String::from("symbol"),
String::from("SH34"),
);
_instance
}

#[ink(message, payable)]
pub fn mint(&mut self, account: AccountId, id: Id) -> Result<(), PSP34Error> {
if Self::env().transferred_value() != 1_000_000_000_000_000_000 {
if self.env().transferred_value() != 1_000_000_000_000_000_000 {
return Err(PSP34Error::Custom(String::from("BadMintValue")));
}
self._mint_to(account, id)

psp34::InternalImpl::_mint_to(self, account, id)
}
}
}