chore: misc improvements #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
force-pushed
the
evalir/misc-improvements
branch
from
aa22c3f to
45c6196
Compare
Evalir
force-pushed
the
evalir/misc-improvements
branch
from
45c6196 to
1407629
Compare
dylanlott
reviewed
Jul 25, 2025
| @@ -8,6 +8,9 @@ use serde::{Deserialize, Serialize}; | |||
| use std::time::Duration; | |||
| use tokio::{sync::mpsc, task::JoinHandle, time}; | |||
|
|
|||
| /// Poll interval for the transaction poller in milliseconds. | |||
| const POLL_INTERVAL_MS: u64 = 1000; | |||
There was a problem hiding this comment.
Question: Why not an env var? If we changed it once here, it seems likely we'll want/need to change it again in the future, so it would likely be useful to have this as an optional env var instead of a hardcoded value.
There was a problem hiding this comment.
I didn't change this, I just made it a constant. I don't think it's also necessarily great to have this as a config value as it can be used to abuse polling the cache by reducing the poll time.
Evalir
commented
Jul 28, 2025
Comment on lines
56
to
+60
| counter!("metrics.tx_succeeded").increment(1); | ||
| debug!("tx succeeded"); | ||
| } else { | ||
| counter!("metrics.tx_reverted").increment(1); | ||
| debug!("tx reverted"); |
dylanlott
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.