Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript conversion of parse5 package #359

Closed
wants to merge 15 commits into from

Conversation

43081j
Copy link
Collaborator

@43081j 43081j commented Nov 21, 2021

All other packages have been left as-is.

I am not expecting this PR to ever land, it is more here as reference (or something?) until we decide what to do about the path forward (potentially a fork).

@fb55 sorry it took me so long to respond to you in the other PR. this is what I was busy doing meanwhile. it'll need somewhere to live, so we should find a place to discuss this since you seem the most willing to maintain a fork.

@fb55
Copy link
Collaborator

fb55 commented Nov 21, 2021

Hi @43081j, great effort! I have already completed a TS port at https://github.com/parse5/parse5-fork, plus a lot of other quality of life improvements & bug fixes. I've invited you to the org in the past, let me know if you're interested in using that as a starting point. Quite unfortunate that conversion efforts were duplicated here :/

@43081j
Copy link
Collaborator Author

43081j commented Nov 21, 2021

yeah very unfortunate. its in a single commit really, which was started a few months ago so i doubt there was any chance we would've crossed paths.

there's a fair amount of stronger types in my branch than in yours, i've seen. if anything, i'd suggest you read through mine. meanwhile i'll have a think about what should happen with this as i feel like both branches have their good parts.

@fb55
Copy link
Collaborator

fb55 commented Feb 13, 2022

Closing this, as the TS conversion was completed in #362. Great effort @43081j, and thanks for helping with my PR!

@fb55 fb55 closed this Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants