Skip to content
This repository has been archived by the owner on Nov 8, 2019. It is now read-only.

Feature/77 allow work labels on user mode #86

Merged
merged 9 commits into from
Mar 20, 2019
Merged

Feature/77 allow work labels on user mode #86

merged 9 commits into from
Mar 20, 2019

Conversation

pcantera
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pcantera pcantera self-assigned this Jul 24, 2018
@pcantera pcantera requested a review from pbanos July 24, 2018 07:17
@codecov
Copy link

codecov bot commented Jul 24, 2018 •
edited
Loading

Codecov Report

Merging #86 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #86      +/-   ##
===========================================
+ Coverage    99.96%   99.96%   +<.01%     
===========================================
  Files           43       45       +2     
  Lines         5448     5731     +283     
===========================================
+ Hits          5446     5729     +283     
  Misses           1        1              
  Partials         1        1
Impacted Files Coverage Δ
api/labels/labels_api_mocked.go 100% <100%> (ø)
utils/format/textformatter.go 100% <100%> (ø) ⬆️
api/labels/labels_api.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 752e7f6...a8670ea. Read the comment docs.

pbanos
pbanos reviewed Aug 6, 2018
View reviewed changes
Copy link
Contributor

@pbanos pbanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a better proposal for the modeling of labelable actions, but we should make sure is technically viable for all label-related operations

api/types/labels.go Outdated Show resolved Hide resolved
blueprint/scripts/subcommands.go Outdated Show resolved Hide resolved
blueprint/scripts/subcommands.go Outdated Show resolved Hide resolved
cmd/labels_cmd.go Outdated Show resolved Hide resolved
Pablo Cantera added 5 commits August 10, 2018 14:21
Allowed work with labels on user-mode (issue #77)
e9f7e28 
For these resources:
 - servers
 - templates
 - scripts
 - ssh_profiles
 - firewall_profiles
Added test cases (issue #77)
af9b960
Populated label names (issue #77)
5a442b7
Updated README (issue #77)
1f2b8c2 
- Removed 'workspaces'
- Added 'labels'
Fixed LabeledResources type name (issue #77)
070f2fa
@pcantera pcantera force-pushed the feature/77-allow-work-labels-on-user-mode branch from 5b26c0c to 070f2fa Compare August 10, 2018 12:40
@pcantera pcantera force-pushed the feature/77-allow-work-labels-on-user-mode branch from 970a850 to e5aef07 Compare March 13, 2019 12:36
@pcantera pcantera force-pushed the feature/77-allow-work-labels-on-user-mode branch from e5aef07 to ac7c4cb Compare March 14, 2019 11:09
pbanos
pbanos approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@pbanos pbanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! We should have someone else review this, since I have collaborated a bit though

utils/utils.go Show resolved Hide resolved
@pbanos pbanos requested review from chris-m-h and sjpatino March 19, 2019 14:32
sjpatino
sjpatino approved these changes Mar 19, 2019
View reviewed changes
Copy link

@sjpatino sjpatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems right ;)

@pbanos pbanos merged commit a628184 into develop Mar 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pbanos pbanos pbanos approved these changes

@sjpatino sjpatino sjpatino approved these changes

@chris-m-h chris-m-h Awaiting requested review from chris-m-h

Assignees

@pcantera pcantera

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcantera @pbanos @sjpatino