Rust wrappers for hash and merkle API #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshekel
requested review from
jeremyfelder,
LeonHibnik,
ChickenLover and
mickeyasa
yshekel
force-pushed
the
yshekel/hash_rust
branch
from
189b746 to
58fd4ab
Compare
emirsoyturk
reviewed
Sep 22, 2024
emirsoyturk
reviewed
Sep 22, 2024
emirsoyturk
reviewed
Sep 24, 2024
|
|
||
| Hash create_sha3_256_hash(uint64_t input_chunk_size) | ||
| { | ||
| std::shared_ptr<HashBackend> backend; | ||
| ICICLE_CHECK(Keccak256Dispatcher::execute(input_chunk_size, backend)); | ||
| ICICLE_CHECK(Sha3_256Dispatcher::execute(input_chunk_size, backend)); | ||
| Hash keccak{backend}; | ||
| return keccak; | ||
| } | ||
|
|
||
| // Keccak 512 |
mickeyasa
reviewed
Sep 24, 2024
| // TODO implement | ||
| ICICLE_LOG_DEBUG << "Keccak/sha3 CPU hash() called, batch=" << config.batch | ||
| << ", single_output_size=" << output_size(); | ||
| // TODO implement real logic |
There was a problem hiding this comment.
yes it's just that it will fail in CI. Aviad has a PR for that already.
mickeyasa
approved these changes
Sep 24, 2024
emirsoyturk
reviewed
Sep 24, 2024
| None, // No padding, assume input is correctly sized. | ||
| ZeroPadding, // Pad the input with zeroes to fit the expected input size. | ||
| LastValue, // Pad the input by repeating the last value. | ||
| } |
There was a problem hiding this comment.
Do we need other padding policies, such as Random Padding, Repeat Padding, etc.?
There was a problem hiding this comment.
Probably yes but we will have to implement them separately
emirsoyturk
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.