[CI] Fix device race in golang tests #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a function that will handle calling runtime.SetDevice
yshekel
approved these changes
Sep 15, 2024
nonam3e
reviewed
Sep 15, 2024
LeonHibnik
approved these changes
Sep 16, 2024
Not sure why that failed. From the values of the failure it looks like the functions didn't run and just returned the default values. Everything passes locally (on multiple machines) consistently. I added a proper exit code for the tests so this would be easier to catch in the future |
jeremyfelder
force-pushed
the
fix/golang-ci-device-race
branch
from
f674f14 to
b58af44
Compare
jeremyfelder
force-pushed
the
fix/golang-ci-device-race
branch
from
8ae6328 to
8a004d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
This PR updates golang tests to include a suite that allows us to wrap each test in a function that will handle calling runtime.SetDevice