Code

Koren/v3 msm#581

Code

Merged

Koren-Brand merged 61 commits intoyshekel/V3ingonyama-zk/icicle:yshekel/V3from Koren/V3_msmingonyama-zk/icicle:Koren/V3_msmCopy head branch name to clipboardAug 29, 2024

+1,553-73

Commits

Commits on Jul 29, 2024

• basic pipenger cpu works

  Koren-Brand

  committed
  80ed037

• works with precompute factor

  Koren-Brand

  committed
  f178ad6

• Signed MSM works

  Koren-Brand

  committed
  d86b02f

• partial cmake commit

  Koren-Brand

  committed
  236c120

• reverted changes in test_curve_api from rebase with yuval's branch

  Koren-Brand

  committed
  8982196

• montgomery works

  Koren-Brand

  committed
  4db229b

• Multithreaded p1 almost works but fails when prints are removed

  Koren-Brand

  committed
  09bec30

• multithreaded phase 1 works plus removed unnecessary initialization of buckets array

  Koren-Brand

  committed
  5c75b6d

• Phase 1 is multithreaded and works. Started writing multithreaded version of phase 2.

  Koren-Brand

  committed
  5c8cbfc

• fix formatting

  Koren-Brand

  committed
  9a179e9

Commits on Jul 30, 2024

• commit before switching to work on one of the servers to compare cpu with gpu

  Koren-Brand

  committed
  3de5508

Commits on Aug 5, 2024

• added framework for generic small tasks thread pool that has yet to be verified against another model (i.e. gpu)

  Koren-Brand

  committed
  fbd0b4e

• added framework for generic small tasks thread pool that has yet to be verified against another model (i.e. gpu)

  Koren-Brand

  committed
  e8cb7e5

• added framework for generic small tasks thread pool that has yet to be verified against another model (i.e. gpu)

  Koren-Brand

  committed
  cec0c38

Commits on Aug 6, 2024

• Added pre-compute factor to cpu-msm test

  Koren-Brand

  committed
  1d37343

• fix: bug where wrong polynomial factory is used to construct polynomial from wrong field

  

  yshekel

  authored and

  Koren-Brand

  committed
  8c13382

• rename template files to not format them

  

  yshekel

  authored and

  Koren-Brand

  committed
  4679729

• fix rust examples calling load_backend() with removed param

  

  yshekel

  authored and

  Koren-Brand

  committed
  72bfcdc

• minor update to rust poly example

  

  yshekel

  authored and

  Koren-Brand

  committed
  67afbd0

• add runtime api to load backend from default installdir and use it everywhere instead of specifying the install dir in the code

  

  yshekel

  authored and

  Koren-Brand

  committed
  94facf8

• add ntt benchmark for rust

  

  yshekel

  authored and

  Koren-Brand

  committed
  7e463e1

• simplify C++ examples by loading backend from default install dir

  

  yshekel

  authored and

  Koren-Brand

  committed
  83d05e6

• fix rust bw761 curve missing ICICLE backend install path and fix examples

  

  yshekel

  authored and

  Koren-Brand

  committed
  7377a69

• add rust benchmark for msm

  

  yshekel

  authored and

  Koren-Brand

  committed
  42a5f99

• add rust ntt benchmark for fields too

  

  yshekel

  authored and

  Koren-Brand

  committed
  1064f27

• add rust ecntt benchmark

  

  yshekel

  authored and

  Koren-Brand

  committed
  0b02d7e

• update ntt api to accept config by const

  

  yshekel

  authored and

  Koren-Brand

  committed
  8bbeae4

• move backend-specific-config to open part to avoid installing it

  

  yshekel

  authored and

  Koren-Brand

  committed
  8db133b

• rename template files to not format them

  

  yshekel

  authored and

  Koren-Brand

  committed
  bded390

• fix rust examples calling load_backend() with removed param

  

  yshekel

  authored and

  Koren-Brand

  committed
  57976e0

• minor update to rust poly example

  

  yshekel

  authored and

  Koren-Brand

  committed
  301c12b

• multiplier works

  

  HadarIngonyama

  authored and

  Koren-Brand

  committed
  db6a954

• add-sub 64 works

  

  HadarIngonyama

  authored and

  Koren-Brand

  committed
  765dac7

Commits on Aug 13, 2024

• phase 2 and phase 3 now work though timing seems to have worsen for phase 1 since the inclusion of tasks manager

  Koren-Brand

  committed
  db68388

Commits on Aug 18, 2024

• All works with some optimizations

  Koren-Brand

  committed
  8b2fe22

• Currently passing affine by reference is not possible efficiently as it needs negation and montgomery conversions that will be repeated N/c times

  Koren-Brand

  committed
  885c2c2

• weird duplicate lines removed

  emirsoyturk

  committed
  2fb7cd0

Commits on Aug 19, 2024

• Reverted Hadar's multiplier addition to the branch such that the cpu msm would be self-consistent in test_curve_api

  Koren-Brand

  committed
  7700032

• merge with yuval's branch

  Koren-Brand

  committed
  9cbb3be

• Merge remote-tracking branch 'origin/yshekel/V3' into Koren/V3_msm

  Koren-Brand

  committed
  fdaf97c

• Final touch ups before PR - removed prints, TODOs etc

  Koren-Brand

  committed
  3da6f43

• rust msm tests full size

  Koren-Brand

  committed
  97d8bb3

• Removing redundant files for PR

  Koren-Brand

  committed
  cabda59

• No need for copy in projective.h

  Koren-Brand

  committed
  18f231f

• format files

  Koren-Brand

  committed
  dccb3d9

• fix G2 issues

  Koren-Brand

  committed
  382c106

• Merge remote-tracking branch 'origin/yshekel/V3' into Koren/V3_msm

  Koren-Brand

  committed
  a66b4c9

• fix formatting

  Koren-Brand

  committed
  993853e

• access c via config, not ext

  Koren-Brand

  committed
  ada7289

Commits on Aug 20, 2024

• Currently MSM does not support a case where c divides scalar without remainder and the tests now reflect that

  Koren-Brand

  committed
  c24a433

• Merge remote-tracking branch 'origin/yshekel/V3' into Koren/V3_msm

  Koren-Brand

  committed
  d11ca7b

• Added c check to msm itself (before it was only in curve tester)

  Koren-Brand

  committed
  03bc89f

• fix potential divison by 0 when not specifying c in config

  Koren-Brand

  committed
  ee94c08

Commits on Aug 25, 2024

• Properly check nof_threads (and existence of config.ext) Also properly modifies c if it divides scalar width

  Koren-Brand

  committed
  f1593ef

• Merge remote-tracking branch 'origin/yshekel/V3' into Koren/V3_msm

  Koren-Brand

  committed
  e7e3f83

Commits on Aug 26, 2024

• FIxed G2 bw-761 definition

  Koren-Brand

  committed
  320a238

• Merge remote-tracking branch 'origin/yshekel/V3' into Koren/V3_msm

  Koren-Brand

  committed
  672d0eb

• spelling and formatting

  Koren-Brand

  committed
  fe13b85

Commits on Aug 28, 2024

• fixed config issues that failed in rust tests

  Koren-Brand

  committed
  97944ba

• Merge remote-tracking branch 'origin/yshekel/V3' into Koren/V3_msm

  Koren-Brand

  committed
  9f6f3a3

• removing limitations on msm size in rust tests

  Koren-Brand

  committed
  04be16e