Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/vlad/affine to proj #552

Merged
merged 5 commits into from
Jul 4, 2024
Merged

Fix/vlad/affine to proj #552

merged 5 commits into from
Jul 4, 2024

Conversation

vladfdp
Copy link
Contributor

@vladfdp vladfdp commented Jul 3, 2024

Describe the changes

This PR fixes some of the affine -> projective functions by adding a condition
If the point in affine form is zero then return the projective zero

Linked Issues

Resolves #

Copy link
Collaborator

@jeremyfelder jeremyfelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the fix.

I don't think it is too much work to extern the from_affine function in cpp and use that directly in Rust and Go so we truly have a single implementation for this logic

vladfdp and others added 3 commits July 3, 2024 10:36
Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
@LeonHibnik LeonHibnik requested a review from jeremyfelder July 3, 2024 10:20
@jeremyfelder
Copy link
Collaborator

I don't think it is too much work to extern the from_affine function in cpp and use that directly in Rust and Go so we truly have a single implementation for this logic

If we choose not to do this for the hotfix, then lets add a test case in both Rust and Go:

@jeremyfelder jeremyfelder merged commit a4b1eb3 into main Jul 4, 2024
25 checks passed
@jeremyfelder jeremyfelder deleted the fix/vlad/affine-to-proj branch July 4, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants