fix: ntt mixed-radix bug regarding large ntts (and/or batch) #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshekel
force-pushed
the
yshekel/large_ntt_bugfix_
branch
2 times, most recently
from
5d6b098 to
7cc5d44
Compare
yshekel
requested review from
HadarIngonyama,
ChickenLover,
jeremyfelder and
LeonHibnik
yshekel
force-pushed
the
yshekel/large_ntt_bugfix_
branch
from
232b275 to
2d33f60
Compare
Yes, for some cases (size+batch) it is a little slower. Sometimes slightly faster (which is odd but). I tried to minimize it. For example I initially made the meta.block_id u64 (Which make all ops with it u64) but then reverted and casted only where I need it (so only some ops are u64 and the struct is smaller etc.). Do you have an idea how to support >4G elements but avoid it? I don't really think it's possible. |
ChickenLover
approved these changes
May 20, 2024
in some cases 32b values would wrap around and cause invalid accesses to wrong elements and memory addresses
yshekel
force-pushed
the
yshekel/large_ntt_bugfix_
branch
from
2d33f60 to
0d3a51f
Compare
HadarIngonyama
approved these changes
May 20, 2024
yshekel
added a commit
that referenced
this pull request
May 23, 2024
in some cases 32b values would wrap around and cause invalid accesses to wrong elements and memory addresses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in some cases 32b values would wrap around and cause invalid accesses to wrong elements and memory addresses