Feature/untangle dataset registry and meta storage #3502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thoniTUB
commented
Jul 24, 2024
Comment on lines
-37
to
-38
| @Getter | ||
| protected final DatasetRegistry<? extends Namespace> datasetRegistry; |
There was a problem hiding this comment.
@awildturtok this went away
Comment on lines
-49
to
-53
| @Getter | ||
| @Setter | ||
| private MetaStorage metaStorage; | ||
|
|
There was a problem hiding this comment.
@awildturtok and this went away
thoniTUB
force-pushed
the
feature/untangle-datasetRegistry-and-MetaStorage
branch
from
aa0004e to
ca8b0eb
Compare
thoniTUB
changed the base branch from
feature/integrate-object-initialization-upon-parsing
to
develop
awildturtok
approved these changes
Jul 25, 2024
| @@ -42,7 +38,7 @@ public T deserialize(JsonParser parser, DeserializationContext ctxt) throws IOEx | |||
| ID id = ctxt.readValue(parser, idClass); | |||
|
|
|||
| try { | |||
| final CentralRegistry centralRegistry = CentralRegistry.get(ctxt); | |||
| final CentralRegistry centralRegistry = MetaStorage.get(ctxt).getCentralRegistry(); | |||
There was a problem hiding this comment.
würde es sich anbieten die CentralRegistry umzubennen, wenn sie hier nur für die MetaIds verantwortlich ist?
There was a problem hiding this comment.
Ich würde davon absehen, da die CentralRegistry mit dem Caching verschwindet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before DatasetRegistry and MetaStorage each referenced each other which complicated instantiation and initialization.
Now:
@awildturtok you can review it but I'll want to rebase this PR onto develop so that it is more independent from the other caching related PRs