Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw proper error message, when query cannot be resolved #3182

Merged
merged 1 commit into from
Sep 27, 2023
Merged

throw proper error message, when query cannot be resolved #3182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions backend/src/main/java/com/bakdata/conquery/apiv1/query/concept/specific/CQReusedQuery.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import com.bakdata.conquery.apiv1.query.Query;
import com.bakdata.conquery.io.cps.CPSType;
import com.bakdata.conquery.io.jackson.View;
import com.bakdata.conquery.models.error.ConqueryError;
import com.bakdata.conquery.models.identifiable.ids.specific.ManagedExecutionId;
import com.bakdata.conquery.models.query.ManagedQuery;
import com.bakdata.conquery.models.query.QueryExecutionContext;
Expand Down Expand Up @@ -74,6 +75,11 @@ public QPNode createQueryPlan(QueryPlanContext context, ConceptQueryPlan plan) {
@Override
public void resolve(QueryResolveContext context) {
query = ((ManagedQuery) context.getStorage().getExecution(queryId));

if(query == null){
throw new ConqueryError.ExecutionCreationResolveError(queryId);
}

resolvedQuery = query.getQuery();

// Yey recursion, because the query might consist of another CQReusedQuery or CQExternal
Expand Down