manual url for internal forms and override support #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e urls provided by external form frontend configs
thoniTUB
force-pushed
the
feature/manual_url_for_internal_forms
branch
from
bd0a985 to
e9a90ad
Compare
thoniTUB
commented
Aug 22, 2022
backend/src/main/java/com/bakdata/conquery/models/forms/frontendconfiguration/FormScanner.java
Outdated
Show resolved
Hide resolved
…ndconfiguration/FormScanner.java
awildturtok
previously approved these changes
Aug 22, 2022
| return null; | ||
| } | ||
| if (!manualUrl.isTextual()) { | ||
| log.warn("FrontendFormConfig {} contained field 'manualUrl' but it was not a text. Was: '{}'.", fullTypeIdentifier, manualUrl.getNodeType()); |
There was a problem hiding this comment.
macht es was, wenn du hier eine exception wirfst? Das ist mMn sinnvoller
delete-merged-branch
bot
deleted the
feature/manual_url_for_internal_forms
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@awildturtok ich muss das noch testen, bin aber erstmal zufrieden mit der mechanik