Infocard for Entity Preview #2616
Conversation
backend/src/main/java/com/bakdata/conquery/apiv1/PreviewFullExecutionStatus.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/apiv1/QueryProcessor.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/apiv1/QueryProcessor.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/apiv1/QueryProcessor.java
Outdated
Show resolved
Hide resolved
| public static CQConcept forSelect(Select select) { | ||
| CQConcept cqConcept = new CQConcept(); | ||
| cqConcept.setElements(List.of(select.getHolder().findConcept())); | ||
| CQTable table = new CQTable(); | ||
| cqConcept.setTables(List.of(table)); | ||
|
|
||
| table.setConnector(((Connector) select.getHolder())); | ||
|
|
||
| table.setSelects(List.of(select)); | ||
|
|
||
| return cqConcept; | ||
| } | ||
|
|
||
| public static CQConcept forConnector(Connector source) { | ||
| final CQConcept cqConcept = new CQConcept(); | ||
| cqConcept.setElements(List.of(source.getConcept())); | ||
| final CQTable cqTable = new CQTable(); | ||
| cqTable.setConcept(cqConcept); | ||
| cqTable.setConnector(source); | ||
| cqConcept.setTables(List.of(cqTable)); | ||
|
|
||
| return cqConcept; | ||
| } |
There was a problem hiding this comment.
Würde ich ein eine Util Klasse packen und doku bitte
backend/src/main/java/com/bakdata/conquery/models/config/PreviewConfig.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/models/query/ManagedQuery.java
Show resolved
Hide resolved
# Conflicts: # backend/src/main/java/com/bakdata/conquery/apiv1/QueryProcessor.java
backend/src/main/java/com/bakdata/conquery/models/query/preview/EntityPreviewForm.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/models/query/preview/EntityPreviewForm.java
Outdated
Show resolved
Hide resolved
| public boolean isSystem() { | ||
| // This Form should NEVER be started manually. Nor persisted | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Der Kommentar klingt so als würde dem system Flag dieser Effekt anhaften, aber an sich ist es ein flag, dass eigentlich mal für das Frontend gedacht war.
There was a problem hiding this comment.
ja ich hatte mir dann noch etwas Zeit genommen versuchen sie nicht zu persisten, dabei kam aber soviel blödsinn und verwirrung zusammen, dass ich es geculled habe :(
backend/src/main/java/com/bakdata/conquery/models/query/preview/EntityPreviewExecution.java
Show resolved
Hide resolved
| @@ -247,7 +247,7 @@ public void getConfigs() { | |||
| mode3.setForm(form); | |||
| mode3.setFeatures(List.of(new CQConcept())); | |||
|
|
|||
| TestForm form3 = new TestForm(); | |||
| TestFormRelUrl form3 = new TestFormRelUrl(); | |||
There was a problem hiding this comment.
hier werden wir gleich einen merge conflict haben
# Conflicts: # backend/src/test/java/com/bakdata/conquery/api/form/config/FormConfigTest.java # backend/src/test/java/com/bakdata/conquery/api/form/config/TestFormAbsUrl.java # docs/Config JSON.md
| /** | ||
| * Used to map {@link SelectResultInfo} to {@link InfoCardSelect#getLabel()} via {@link PrintSettings#getColumnNamer()}. | ||
| */ | ||
| public String resolveSelectLabel(SelectResultInfo info) { |
There was a problem hiding this comment.
Wo spielt der PrintSettings#getColumnNamer() hier rein?
There was a problem hiding this comment.
Schau mal in com.bakdata.conquery.models.query.preview.EntityPreviewExecution#transformQueryResultToInfos
| /** | ||
| * Find infoCard-selects by id within Dataset. | ||
| */ | ||
| public List<Select> resolveInfoCardSelects(Dataset dataset, DatasetRegistry registry) { |
There was a problem hiding this comment.
laut gh wird die methode in dieser Datei Zeile 395 benutzt 🤔
There was a problem hiding this comment.
Werden die Funktionen noch benutzt?
There was a problem hiding this comment.
com.bakdata.conquery.apiv1.QueryProcessor#getSingleEntityExport Zeile 395
No description provided.