Add selected item already in state reducer #2594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since onStateChange only gets called on state diff, and selectedItem isn't cleared when an item is removed, it won't "change", when it's removed and re-added again. So we didn't get the change. There also doesn't seem to be a way to clear selectedItem, except for reset, which would also reset the menu (--> close it). Solution: we don't use onStateChange anymore, but a side effect of the stateReducer instead. Doesn't feel great, but seems to work. The downshift docs are wrong, recommending to call addSelectedItem in onStateChange, because all of their examples work with a closing menu, after selecting one item. We're keeping the menu open.
Kadrian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since onStateChange only gets called on state diff,
and selectedItem isn't cleared when an item is removed,
it won't "change", when it's removed and re-added again.
So we didn't get the change.
There also doesn't seem to be a way to clear selectedItem, except for
reset, which would also reset the menu (--> close it).
Solution: we don't use onStateChange anymore, but a side effect of
the stateReducer instead. Doesn't feel great, but seems to work.
The downshift docs are wrong, recommending to call addSelectedItem in
onStateChange, because all of their examples work with a closing menu,
after selecting one item.
We're keeping the menu open.