start and done reporters centrally, removes to many reports #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awildturtok
reviewed
Jul 6, 2022
| if (!child.isDone()) { | ||
| log.warn("One or more Children are not done yet"); | ||
| } | ||
| child.done(); |
There was a problem hiding this comment.
hmm, das eigentlich schon richtig so, dass parent ein Problem hat, wenn child noch nicht fertig ist.
There was a problem hiding this comment.
Ich würde es immer so machen, dass wenn parent done auf ruft auch die children auf done gesetzt werden.
Children sind normalerweise eigene Threads auf die der Parent warten sollte um sicher zugehen, dass der Job abgeschlossen ist. So ist es momentan auch.
awildturtok
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.