Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo some unnecessary interface methods from ResultProviders. #2514

Merged
merged 3 commits into from
May 25, 2022

Conversation

awildturtok
Copy link
Collaborator

No description provided.

@awildturtok awildturtok requested a review from thoniTUB May 25, 2022 12:19
thoniTUB
thoniTUB previously approved these changes May 25, 2022
Copy link
Collaborator

@thoniTUB thoniTUB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alles gut :)

Comment on lines 116 to 118
finally {
onClose.run();
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In ResultArrowProcessor.java hast du noch eine finale log message drinne wenn alle Daten übertragen sind. Die ist ganz nice

@awildturtok awildturtok merged commit 84b6e3b into develop May 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/undo-usage-of-shared-interface branch May 25, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants