rel export combine feature+outcome date ranges #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awildturtok
reviewed
May 18, 2022
| @@ -19,4 +22,7 @@ | |||
| * @return the localization or a fallback. | |||
| */ | |||
| String toString(Locale locale); | |||
|
|
|||
| @CPSBase | |||
| interface Provider extends BiFunction<Object,Locale,String>{} | |||
There was a problem hiding this comment.
Suggested change
| interface Provider extends BiFunction<Object,Locale,String>{} | |
| @FunctionalInterface | |
| interface Provider { | |
| public String apply(Object value, Locale locale); | |
| } |
There was a problem hiding this comment.
Jetzt könntest du sogar generische Sachen damit machen, und mir fehlt an der Klasse etwas Dokumentation
| //features | ||
| resultInfos.addAll(featureInfos); | ||
| resultInfos.addAll(outcomeInfos); | ||
|
|
||
| return resultInfos; | ||
| } | ||
|
|
||
|
|
||
| private boolean hasMultipleObservationScopes(List<ResultInfo> featureInfos, List<ResultInfo> outcomeInfos) { |
| @@ -25,10 +28,10 @@ public class ConqueryConstants { | |||
| public static final String SINGLE_RESULT_TABLE_NAME = "results"; | |||
| public static final ResultInfo CONTEXT_INDEX_INFO = new LocalizedDefaultResultInfo((l) -> C10N.get(ResultHeadersC10n.class, l).index(), ResultType.IntegerT.INSTANCE); | |||
| public static final ResultInfo DATE_RANGE_INFO = new LocalizedDefaultResultInfo((l) -> C10N.get(ResultHeadersC10n.class, l).dateRange(), ResultType.DateRangeT.INSTANCE); | |||
| public static final ResultInfo RESOLUTION_INFO = new LocalizedDefaultResultInfo((l) -> C10N.get(ResultHeadersC10n.class, l).resolution(), ResultType.ResolutionT.INSTANCE); | |||
| public static final ResultInfo RESOLUTION_INFO = new LocalizedDefaultResultInfo((l) -> C10N.get(ResultHeadersC10n.class, l).resolution(), new ResultType.StringLocalizedT(new Resolution.LocalizationProvider())); | |||
There was a problem hiding this comment.
Ich weiß immer blöd der letzte der was angefasstt zu haben zu sein, aber kannst du die ResultInfos hier dokumentieren?
| return result; | ||
| } | ||
|
|
||
| private int getDateRangeResultPosition() { | ||
| return constantCount - 1; | ||
| return constantCount - (withObservationScope ? 2 : 1 ); |
There was a problem hiding this comment.
Suggested change
| return constantCount - (withObservationScope ? 2 : 1 ); | |
| return constantCount - 1 - (withObservationScope ? 1 : 0 ); |
There was a problem hiding this comment.
Oder
Suggested change
| return constantCount - (withObservationScope ? 2 : 1 ); | |
| if(withObservationScope) return constantCount - 2; | |
| return constantCount - 1; |
| private int getFirstAggregatorPosition() { | ||
| if (outcomePlan.getAggregatorSize() <= 0 && featurePlan.getAggregatorSize() <= 0) { | ||
| throw new ConqueryError.ExecutionProcessingError(); | ||
| } | ||
| if (outcomePlan.getAggregatorSize() > 0 && featurePlan.getAggregatorSize() <= 0 | ||
| || featurePlan.getAggregatorSize() > 0 && outcomePlan.getAggregatorSize() <= 0) { | ||
| if (isSingleScope()) { |
There was a problem hiding this comment.
Dass beides geht ist noch drin? Will man nicht auf nur ein Scope komplett umsteigen?
|
Sind vor allem Kleinigkeiten aber über Doku würde ich mich freuen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.