Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implements default and defaultValues for Connectors, Filters and Selects #2148

Merged
merged 5 commits into from
Nov 1, 2021

Conversation

awildturtok
Copy link
Collaborator

No description provided.

@awildturtok awildturtok requested a review from thoniTUB October 12, 2021 14:44
@awildturtok awildturtok changed the title implements defaultValue passing from config to FEFilter implements default and defaultValues for Connectors, Filters and Selects Oct 13, 2021
@awildturtok awildturtok requested a review from Njimefo October 13, 2021 09:06
Comment on lines +18 to +19
@JsonProperty("default")
private Boolean isDefault;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ist @JsonProperty("default") hier notwendig?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Macht Jackson das is nicht automatisch?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

das wäre Lombok denke was das setzt, aber ich kann das Feld selber nicht default nennen. So ist das denke ich sauberer.

@awildturtok awildturtok merged commit e722d53 into develop Nov 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the feature/default-filter-value branch November 1, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants