Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/updating central registry #2063

Merged
merged 3 commits into from
Sep 2, 2021
Merged

Conversation

thoniTUB
Copy link
Collaborator

@thoniTUB thoniTUB commented Sep 1, 2021

No description provided.

@thoniTUB thoniTUB changed the base branch from develop to release September 1, 2021 11:24
@thoniTUB thoniTUB requested a review from awildturtok September 1, 2021 13:58
Copy link
Collaborator

@awildturtok awildturtok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

}

centralRegistry.update(value);
onAdd.accept(value);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wie besprochen, fehlt hier onRemove

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ich habe on remove ergänzt, und im SingletonStore onupdate wieder entfernt

@thoniTUB thoniTUB requested a review from awildturtok September 1, 2021 15:11
@thoniTUB thoniTUB merged commit dc09f89 into release Sep 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/updating-central-registry branch September 2, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants