allow reexecutions only for the owner #2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awildturtok
previously approved these changes
Aug 23, 2021
|
Ja Tags und Labels würden dabei nicht übernommen werden. Das sollten wir nochmal besprechen |
|
@awildturtok ich habe es jetzt so angepasst, dass eine Kopie mit gleichem Namen und gleichen Tags erzeugt wird. Beides ist dann aber nicht an das Original gekoppelt |
awildturtok
requested changes
Aug 26, 2021
| @@ -159,6 +154,15 @@ | |||
| } | |||
| } | |||
|
|
|||
| // If the user is not the owner of the execution, we definitely create a new Execution, so the owner can cancel it | |||
| if (!user.equals(execution.getOwner())) { | |||
There was a problem hiding this comment.
hatten wir nicht sogar eine isOwner Methode?
backend/src/test/java/com/bakdata/conquery/integration/tests/ReusedQueryTest.java
Show resolved
Hide resolved
awildturtok
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address that shareholders cannot cancel reexecutions. Shareholders create their own execution, when they execute a share.