Adds option to list all elements instead of doing a search #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thoniTUB
requested changes
Aug 24, 2021
backend/src/main/java/com/bakdata/conquery/resources/api/ConceptsProcessor.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/resources/api/ConceptsProcessor.java
Outdated
Show resolved
Hide resolved
Comment on lines
284
to
291
| .stream() | ||
| .sorted(Map.Entry.comparingByKey()) | ||
| .map(entry -> entry.getValue().items) | ||
| .flatMap(Collection::stream) | ||
| .distinct() | ||
| .skip(offset) | ||
| .limit(limit) | ||
| .collect(Collectors.toList()); |
There was a problem hiding this comment.
müsstest du nach dem flapMap, nicht auch nochmal sortieren?
There was a problem hiding this comment.
Das war eine bewusste Entscheidung deren Grund ich leider nicht mehr weiß. Mache mir mal einen Test und schaue was rauskommt.
There was a problem hiding this comment.
ok, es wird so dann nach den labels/keywords sortiert was denke ich richtig ist.
There was a problem hiding this comment.
hab dir einen Test beigelegt
|
@thoniTUB ich habe das auflisten mal weiter runtergeschoben um den code so zu vereinheitlichen. |
thoniTUB
reviewed
Aug 24, 2021
backend/src/test/java/com/bakdata/conquery/util/search/QuickSearchTest.java
Outdated
Show resolved
Hide resolved
thoniTUB
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.