Rework of IdMapping toward explicit Id-kinds #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tated Ids instead of guessing the used Ids Also refactors reading of IdMapping to use Headers and not indices, we don't need insane performance here anyway
…m/bakdata/conquery into feature/external-headers-reworked
Also expose available FormatColumns under FontendConfig
thoniTUB
reviewed
Jul 9, 2021
...end/src/main/java/com/bakdata/conquery/apiv1/query/concept/specific/external/CQExternal.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/bakdata/conquery/apiv1/query/concept/specific/external/DateSetColumn.java
Outdated
Show resolved
Hide resolved
...d/src/main/java/com/bakdata/conquery/apiv1/query/concept/specific/external/FormatColumn.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/apiv1/query/concept/specific/external/IdColumn.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/models/config/FrontendConfig.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/models/identifiable/mapping/EntityIdMap.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/models/identifiable/mapping/EntityIdMap.java
Outdated
Show resolved
Hide resolved
Comment on lines
+71
to
+79
| try { | ||
| execution.initExecutable(datasets, config); | ||
| }catch (Exception e){ | ||
| log.error("Failed to initialize Query[{}]", execution.getId(), e); | ||
|
|
||
| //TODO we don't want to store completely faulty queries but is that right like this? | ||
| datasets.getMetaStorage().removeExecution(execution.getId()); | ||
| throw e; | ||
| } |
There was a problem hiding this comment.
Du hast in ManagedExecution schon ein try-catch, aber schluckst die Exception dort
There was a problem hiding this comment.
Öhm jetzt sehe ich ManagedExecution nicht mehr in den Änderungen. hast du die reverted?
backend/src/main/java/com/bakdata/conquery/resources/admin/rest/AdminDatasetProcessor.java
Show resolved
Hide resolved
backend/src/test/java/com/bakdata/conquery/integration/common/LoadingUtil.java
Show resolved
Hide resolved
…m/bakdata/conquery into feature/external-headers-reworked
also implement resolving of DateFormat
thoniTUB
previously approved these changes
Aug 5, 2021
Merged
…d' into feature/localized-date # Conflicts: # backend/src/main/java/com/bakdata/conquery/io/result/excel/ResultExcelProcessor.java # backend/src/main/java/com/bakdata/conquery/models/externalservice/ResultType.java # docs/Config JSON.md # docs/REST API JSONs.md
Feature/localized date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactors reading of IdMapping to use Headers and not indices, we don't need insane performance here anyway