feat: add option to set templated flag #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the pending draft RFC[^1], a link can be marked as `templated` as defined in section 5.2: > 5.2. templated > The "templated" property is OPTIONAL. > > Its value is boolean and SHOULD be true when the Link Object's "href" property is a URI Template. > > Its value SHOULD be considered false if it is undefined or any other value than true. [^1]: https://datatracker.ietf.org/doc/html/draft-kelly-json-hal-11
|
Hi @yitsushi, thank you for the contribution and for bringing attention to the RFC. The May I request you include a docstring above the Templated property to explain its purpose, with a link to the RFC section? Thank you in advance :-) |
survivorbat
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the pending draft RFC1, a link can be marked as
templatedas defined in section 5.2:Footnotes
https://datatracker.ietf.org/doc/html/draft-kelly-json-hal-11 ↩