Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous pipeline updates #58

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Miscellaneous pipeline updates #58

merged 2 commits into from
Nov 9, 2022

Conversation

atreyasha
Copy link
Member

@atreyasha atreyasha commented Nov 8, 2022

  1. Use the --full_determinism flag for the trainer (we already do this, but the trainer does it again apparently)
  2. We should use indent=4 for JSON dumps to be consistent across all pipelines

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Coverage

Coverage Report
FileStmtsMissCoverMissing
parser.py00100% 
privacy_glue.py00100% 
reading_comprehension.py00100% 
sequence_classification.py00100% 
sequence_tagging.py0558%9, 12, 15, 18, 21
tasks
   opp_115.py00100% 
   piextract.py00100% 
   policy_detection.py00100% 
   policy_ie_a.py00100% 
   policy_ie_b.py00100% 
   policy_qa.py00100% 
   privacy_qa.py00100% 
utils
   experiment_utils.py00100% 
   logging_utils.py00100% 
   parser_utils.py00100% 
   pipeline_utils.py00100% 
   task_utils.py00100% 
   trainer_utils.py00100% 
TOTAL822599% 

Tests Skipped Failures Errors Time
1397 210 💤 0 ❌ 0 🔥 33.283s ⏱️

@atreyasha atreyasha changed the title Add explicit JSON indent to all prediction dumps Miscellaneous pipeline updates Nov 8, 2022
Update integration tests as well
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Coverage

Coverage Report
FileStmtsMissCoverMissing
parser.py00100% 
privacy_glue.py00100% 
reading_comprehension.py00100% 
sequence_classification.py00100% 
sequence_tagging.py0558%9, 12, 15, 18, 21
tasks
   opp_115.py00100% 
   piextract.py00100% 
   policy_detection.py00100% 
   policy_ie_a.py00100% 
   policy_ie_b.py00100% 
   policy_qa.py00100% 
   privacy_qa.py00100% 
utils
   experiment_utils.py00100% 
   logging_utils.py00100% 
   parser_utils.py00100% 
   pipeline_utils.py00100% 
   task_utils.py00100% 
   trainer_utils.py00100% 
TOTAL822599% 

Tests Skipped Failures Errors Time
1397 210 💤 0 ❌ 0 🔥 36.541s ⏱️

@atreyasha atreyasha merged commit adf4409 into main Nov 9, 2022
@atreyasha atreyasha deleted the as/patch-pipelines branch November 9, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant