Add Missing Optional Annotation for Port #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sthwang-metal
force-pushed
the
sthwang/make-port-optional
branch
4 times, most recently
from
d0becdc to
96dc3b4
Compare
sthwang-metal
force-pushed
the
sthwang/make-port-optional
branch
3 times, most recently
from
19e8d04 to
fb722ea
Compare
rizzza
previously approved these changes
Jan 26, 2024
Signed-off-by: Stephen Hwang <126002920+sthwang-metal@users.noreply.github.com>
Signed-off-by: Stephen Hwang <126002920+sthwang-metal@users.noreply.github.com>
sthwang-metal
force-pushed
the
sthwang/make-port-optional
branch
from
0fb8053 to
9adfb79
Compare
Signed-off-by: Stephen Hwang <126002920+sthwang-metal@users.noreply.github.com>
sthwang-metal
force-pushed
the
sthwang/make-port-optional
branch
from
9adfb79 to
970284c
Compare
rizzza
approved these changes
Feb 27, 2024
Merged
via the queue into
infratographer:main
with commit Feb 27, 2024
77a0ab5
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Add missing annotation to make port name optional.
Regenerated and fixed tests.