Move secrets to secrets resource #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR moves the NATS token and `accessToken.soure.clientCredentials.clientSecret` out from the configMap and into secrets loaded as environment variables in the container. FileToken.TokenPath gets flagged by secrets scanners despite it not being a sensitive credential, so that got renamed to just `File` which still makes sense in the config path `accessToken.source.file.tokenPath`. AccessToken was also giving chart consumers trouble with security scans Signed-off-by: Adam Mohammed <admohammed@equinix.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
======================================
Coverage ? 9.77%
======================================
Files ? 22
Lines ? 696
Branches ? 0
======================================
Hits ? 68
Misses ? 622
Partials ? 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jacobsee
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the NATS token and
accessToken.source.clientCredentials.clientSecretout from the configMap and into secrets loaded as environment variables in the container.FileToken.TokenPath gets flagged by secrets scanners despite it not being a sensitive credential, so that got renamed to just
Filewhich still makes sense in the config pathaccessToken.source.file.tokenPath.AccessToken was also giving chart consumers trouble with security scans, so that was renamed to accessTokenProvider.
Breaking changes from existing chart:
accessTokentoaccessTokenProvideraccessTokenProvider.source.fileToken.tokenPathtoaccessTokenProvider.source.file.tokenPath(s/fileToken/file/)iam-runtime-infratographer.secretswithin the namespace if loading configuration fromevents.nats.tokenandaccessTokenProvider.source.clientCredentials.clientSecretfor the runtime.