Add config option for JWT issuer and require iat/exp claims in token #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runtime users should be validating the JWT issuer in addition to the JWKS. This commit adds logic to configure the expected issuer for a JWT and updates the token parser to require the "iat" and "exp" claims be present for a given token. Additionally, this commit fixes an error where command line flags were not being bound to Viper configs properly. Signed-off-by: John Schaeffer <jschaeffer@equinix.com>
mikemrm
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime users should be validating the JWT issuer in addition to the JWKS. This PR adds logic to configure the expected issuer for a JWT and updates the token parser to require the "iat" and "exp" claims be present for a given token. Additionally, this PR fixes an error where command line flags were not being bound to Viper configs properly.