Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement grpc health check service #105

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

mikemrm
Copy link
Contributor

@mikemrm mikemrm commented Jan 7, 2025

This implements the standard grpc health check service methods.

Extending each underlying service library to include a HealthCheck method called by the GRPC HealthService Check.

This implements the standard grpc health check service methods.

Extending each underlying service library to include a HealthCheck method called by the GRPC HealthService Check.

Signed-off-by: Mike Mason <mimason@equinix.com>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 242 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@cc9f3d3). Learn more about missing BASE report.

Files with missing lines Patch % Lines
internal/server/server.go 0.00% 79 Missing ⚠️
internal/accesstoken/tokensource.go 0.00% 42 Missing ⚠️
internal/permissions/client.go 0.00% 39 Missing ⚠️
internal/jwt/validator.go 0.00% 31 Missing ⚠️
internal/server/health.go 0.00% 31 Missing ⚠️
internal/eventsx/publisher.go 0.00% 19 Missing ⚠️
internal/server/config.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage        ?   32.58%           
=======================================
  Files           ?       29           
  Lines           ?     1955           
  Branches        ?        0           
=======================================
  Hits            ?      637           
  Misses          ?     1300           
  Partials        ?       18           
Flag Coverage Δ
unittests 32.58% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikemrm mikemrm marked this pull request as ready for review January 7, 2025 20:38
@mikemrm mikemrm requested review from a team as code owners January 7, 2025 20:38
@mikemrm mikemrm merged commit 259d2a6 into infratographer:main Jan 8, 2025
4 checks passed
@mikemrm mikemrm deleted the add-health-service branch January 8, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants