Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): add a widget to workspace to select features by geometry #1627

Open
wants to merge 13 commits into
base: next
Choose a base branch
from

Conversation

pelord
Copy link
Member

@pelord pelord commented Feb 5, 2024

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?
add a widget to workspace to select features by geometry](8dd10b5)

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@pelord
Copy link
Member Author

pelord commented Feb 5, 2024

image

@alecarn
Copy link
Collaborator

alecarn commented Feb 7, 2024

Vu que c'est l'ajout d'une feature, est-ce qu'on pourrait créer un ticket et documenter le besoin et le fonctionnement?

On voit en screenshot la fonctionnalité en fonction mais pour l'activé comment qu'on fait? C'est un bouton qu'on ajoute dans le tableau du workspace?

@pelord
Copy link
Member Author

pelord commented Feb 7, 2024

@alecarn related to #1629

@alecarn alecarn linked an issue Feb 7, 2024 that may be closed by this pull request
@alecarn alecarn changed the base branch from next to release/16.3.x February 19, 2024 20:06
@alecarn
Copy link
Collaborator

alecarn commented Apr 9, 2024

Est-ce qu'on pourrait se rebaser sur la branche NEXT?

@pelord
Copy link
Member Author

pelord commented Apr 9, 2024

Bonne idée

@pelord
Copy link
Member Author

pelord commented Apr 9, 2024

fait.

@pelord pelord changed the base branch from release/16.x to next April 9, 2024 19:38
@alecarn
Copy link
Collaborator

alecarn commented Aug 22, 2024

J'ai fait des tests et quelques non conformités ou comportement a définir:

  1. Ouverture du panneau de sélection, lorsqu'on le ferme on conserve toujours le curseur pour dessiner la géométrie
  2. Style centré avec le panneau du workspace? Sinon ça fait étrange avec le background grisé image
  3. Le bouton réinitialiser ne semble pas fonctionner
  4. Est-ce qu'il faudrait mentionner que la sélection se fait seulement côté client?
  5. Semble avoir plusieurs problèmes lorsqu'on ferme et qu'on ouvre les panneaux de workspace/sélection https://github.com/user-attachments/assets/42f1dc54-863d-4ef8-b0fc-512e2de31aaf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a widget to workspace to select features by geometry
2 participants