-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Channel control changes + ability to save channel config + image color histogram #78
Conversation
After discussing about the filters I realized what we're doing is completely wrong. We're not supposed to change the R G B values for contrast/brightness/gamma, and instead we should modify the value (v in hsv format). I also made sure that we're doing this once so we don't have to go over the pixels multiple times.
After discussing the changes with @karlcz I realized what I'm doing for the filters is completely wrong. Each filter is supposed to change only part of the color value. I was applying all the function to each R G B value, but
So I made the proper changes and also
|
…-viewer into channel-controls
…-viewer into channel-controls
We had another discussion about this and decided that I should generate a intensity (value) histogram as a debugging tool so it's easier to figure out how the filters are working (for brightfield maybe RGB histogram might be better) and Ideally we might want both the before and after histograms. Eventually we might want to change our filter logic to be based on the displayed image, and therefore we would need to know the min/max/medium intensity of the image. Ideally this should be generated once on load based on the highest resolution of image. But since that's not feasible we might want to do this based on the top of the pyramid image. Other requested changes are:
|
requires debugging
- add a message to signal channel-list to show the save button. - modify contrast to allow finer value selection - change brightness logic to also apply the contrast factor
…-viewer into channel-controls
…-viewer into channel-controls
We realized that the contrast/brightness are difficult for users. So instead we decided to implement a intensity range. Users can pick the |
This PR will add tooltips to osd viewer. Summary of changes: