Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log changes #829

Merged
merged 7 commits into from
Feb 12, 2020
Merged

Log changes #829

merged 7 commits into from
Feb 12, 2020

Conversation

RFSH
Copy link
Member

@RFSH RFSH commented Jan 17, 2020

These changes are part of chaise#1879 issue. The main changes are in chaise and the changes in ermrestjs just include some API changes that chaise is going to use now. This PR,

  • Modifies the defautlLogInfo to only return catalog and schema_table.
  • Adds the new filterLogInfo that will return the filter information of the reference that can be used in logs.
  • Changes the dataSource info compressedDataSource since it was only used by logs and in logs, we want the compressed version.
  • Adds more log information in update and create functions.
  • Handles the changing of action name to auto-reload for the cases that we have to correct the given page information.
  • Modifies the _certifyContextHeader function (header truncation logic) to support the new log syntax.

RFSH added 2 commits January 16, 2020 16:50
These api changes were required for the changes that I was making
to the chaise logs.
@RFSH RFSH self-assigned this Jan 17, 2020
RFSH added 4 commits January 28, 2020 17:31
- add log information to udpate and create
- fix the export log bug
- added getElapsedTime api
- added pollyfil for Number.isInteger
- Update _certifyContextHeader 
- update schema and catalog actions
@RFSH RFSH requested a review from jrchudy February 10, 2020 22:34
Copy link
Member

@jrchudy jrchudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To rephrase what you wrote in the description:
Looks like you modified how the stack is being generated and added more getters to get more unique values for different parts of the stack.

@RFSH RFSH merged commit f7f87a8 into master Feb 12, 2020
@RFSH RFSH deleted the log-stack branch November 19, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants