Fix async tests by using tokio runtime #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- delete futures crate from Cargo.toml - add tokio as a dev dependency
liamsi
force-pushed
the
fix_tests/rpc/async
branch
from
a94348f
to
18a6088
Compare
xla
approved these changes
Dec 11, 2019
|
Thanks for reviewing @xla!
Is this sth. we should be concerned about in the context of this PR? Is that easy to get wrong in tests (create multiple Runtimes with distinct thread-pools)? I do not understand enough about the internals of the runtime to understand when we would need to worry about this. |
|
This got manually merged into #85 (comment). Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses tokio runtime builder to create a
block_onmethod (depends on #85).Tested locally by re-enabling some of the ignored tests: most pass, some do not. Looks like the JSON format changed in the meantime.