Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prep v0.14.0 release #347

Merged
merged 8 commits into from
Jun 19, 2020
Merged

Prep v0.14.0 release #347

merged 8 commits into from
Jun 19, 2020

Conversation

liamsi
Copy link
Member

@liamsi liamsi commented Jun 19, 2020 •
edited
Loading

rendered changelog: https://github.com/informalsystems/tendermint-rs/blob/ismail/release/prep_v0.14.0/CHANGES.md#0140-2020-06-19

closes #344

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGES.md

xla
xla reviewed Jun 19, 2020
View reviewed changes
Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CHANGES.md is missing an entry for the feature flagging of rpc::client, someone was too quick on the merge button. :p The PR is #343

@liamsi
Copy link
Member Author

liamsi commented Jun 19, 2020 •
edited
Loading

someone was too quick on the merge button. :p The PR is #343

I can be impatient, too :-P

It's still in draft, I'll add this and:

  • mention the light client refactor
  • add deprecation warning for lite module
  • short summary of changes (it looks like we've did a lot but there is not that much)

@liamsi
Changelog:
ea76397 
 - add summary
 - include references only once to make
 changelog more readable
 - add #343
 - rephrase some
 - consistent refs ([#num])
@liamsi liamsi marked this pull request as ready for review June 19, 2020 14:53
@liamsi liamsi requested a review from xla June 19, 2020 14:53
@liamsi liamsi changed the title Ismail/release/prep v0.14.0 Prep v0.14.0 release Jun 19, 2020
tarcieri
tarcieri previously approved these changes Jun 19, 2020
View reviewed changes
liamsi
liamsi commented Jun 19, 2020
View reviewed changes
CHANGES.md Outdated Show resolved Hide resolved
@liamsi liamsi requested a review from tarcieri June 19, 2020 15:08
liamsi
liamsi commented Jun 19, 2020
View reviewed changes
tendermint/src/lib.rs
@@ -13,7 +13,7 @@
unused_qualifications
)]
#![forbid(unsafe_code)]
#![doc(html_root_url = "https://docs.rs/tendermint/0.13.0")]
#![doc(html_root_url = "https://docs.rs/tendermint/0.14.0")]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add this to sub-crates too:
https://doc.rust-lang.org/rustdoc/the-doc-attribute.html#html_root_url

xla
xla approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small consistency change.

🏸 ♑️ 📀 ©️

light-client/Cargo.toml
@@ -3,10 +3,11 @@ name = "tendermint-light-client"
version = "0.1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "0.1.0"
version = "0.14.0"

For consistency.

@liamsi liamsi merged commit dcd740d into master Jun 19, 2020
@liamsi liamsi deleted the ismail/release/prep_v0.14.0 branch June 19, 2020 15:24
This was referenced Jun 19, 2020
Merged
Closed
@xla xla linked an issue Jun 19, 2020 that may be closed by this pull request
Prevent accidental publication of light-client and light-node crates to Crates.io #317
Closed
@tarcieri
Copy link
Contributor

@xla can you (or someone else) publish tendermint-rpc?

@liamsi
Copy link
Member Author

liamsi commented Jun 19, 2020

working on it:

Finished dev [unoptimized + debuginfo] target(s) in 1m 10s
   Uploading tendermint-rpc v0.14.0 (/Users/ismail/IdeaProjects/tendermint-rs/rpc)
error: api errors (status 200 OK): missing or empty metadata fields: license. Please see https://doc.rust-lang.org/cargo/reference/manifest.html for how to upload metadata

tarcieri pushed a commit to iqlusioninc/tmkms that referenced this pull request Jun 19, 2020
@tony-iqlusion
Bump tendermint(-rpc) to v0.14
77e752f 
Uses the latest release of the `tendermint` crate:

informalsystems/tendermint-rs#347
@tony-iqlusion tony-iqlusion mentioned this pull request Jun 19, 2020
Merged
tony-iqlusion added a commit to iqlusioninc/tmkms that referenced this pull request Jun 19, 2020
@tony-iqlusion
Bump tendermint(-rpc) to v0.14 (#83)
6f749cc 
Uses the latest release of the `tendermint` crate:

informalsystems/tendermint-rs#347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xla xla xla approved these changes

@greg-szabo greg-szabo Awaiting requested review from greg-szabo

@brapse brapse Awaiting requested review from brapse

@tarcieri tarcieri Awaiting requested review from tarcieri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New v0.14 (pre-)release? Prevent accidental publication of light-client and light-node crates to Crates.io
3 participants
@liamsi @tarcieri @xla