-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPC support for CometBFT 0.38 #1317
Commits on May 19, 2023
-
rpc: 0.38 support for /block_results endpoint
In the v0_37+ dialect helper, support the new finalize_block_events field if it is present. Also default the begin_block_events and end_block_events fields to None if they are not present.
Configuration menu - View commit details
-
Copy full SHA for 9962a4f - Browse repository at this point
Copy the full SHA 9962a4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8328820 - Browse repository at this point
Copy the full SHA 8328820View commit details -
tendermint: restore Deserialize on some types
For abci::Event and abci::response::CheckTx, restore the Deserialize implementation on domain types themselves. The event serialization format as used in 0.37+ will be established as the "canonical" serialization.
Configuration menu - View commit details
-
Copy full SHA for 320decd - Browse repository at this point
Copy the full SHA 320decdView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad73c4b - Browse repository at this point
Copy the full SHA ad73c4bView commit details -
rpc: support more changes in CometBFT 0.38
Add the new fields and types without static differentiation for 0.38.x. Use the domain type ExecTxResult in deserializing the endpoint response types in the current (i.e. 0.37+) dialect for these endpoints: - /block_results - /broadcast_tx_commit - /tx - /tx_commit The Deserialize impls are restored on the response types, corresponding to the JSON schema for the current RPC dialect. Simplify the 0.34 dialect support for these responses, no longer using generics. In endpoint::tx_commit::Response, rename the deliver_tx field to tx_result to correspond to the current JSON schema. The Deserialize impl falls back to deliver_tx to also be able to parse 0.37 responses.
Configuration menu - View commit details
-
Copy full SHA for 4c0cb74 - Browse repository at this point
Copy the full SHA 4c0cb74View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14cda47 - Browse repository at this point
Copy the full SHA 14cda47View commit details
Commits on May 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ba70456 - Browse repository at this point
Copy the full SHA ba70456View commit details -
Fix deserialization of RPC results
Some serde attributes were not migrated onto the ExecTxResult domain type when it has been tasked with deserializing the latest RPC dialect. On abci::response::CheckTx, add serde(default) on fields that are no longer present in CometBFT 0.38.
Configuration menu - View commit details
-
Copy full SHA for c8d8497 - Browse repository at this point
Copy the full SHA c8d8497View commit details -
rpc: 0.37 compat on /block_results response
If the finalize_block_events is not present, default to an empty vector. Conversely, skip the field from serializing if it's set to an empty vector.
Configuration menu - View commit details
-
Copy full SHA for 009e696 - Browse repository at this point
Copy the full SHA 009e696View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ba4b1c - Browse repository at this point
Copy the full SHA 7ba4b1cView commit details
Commits on May 24, 2023
-
Derive serde impls for abci responses
BeginBlock, EndBlock, FinalizeBlock are used to deserialize RPC responses.
Configuration menu - View commit details
-
Copy full SHA for 057f169 - Browse repository at this point
Copy the full SHA 057f169View commit details
Commits on May 25, 2023
-
rpc: adapt serialization of Event for 0.38
Now that event data can have new fields, distinguish this with a new NewBlock enum variant, renaming the old one to LegacyNewBlock. The dialect serialization helpers for subscription events are separated to v0_34::DialectEvent, that does not recognize the 0.38 fields at all and parses the event attributes as base64-encoded, and latest::DialectEvent, which has provisions for 0.38 fields if they are present, and in this case converts to the NewBlock variant.
Configuration menu - View commit details
-
Copy full SHA for ce199fa - Browse repository at this point
Copy the full SHA ce199faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 07de311 - Browse repository at this point
Copy the full SHA 07de311View commit details -
Configuration menu - View commit details
-
Copy full SHA for c37c6c3 - Browse repository at this point
Copy the full SHA c37c6c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2cf5d78 - Browse repository at this point
Copy the full SHA 2cf5d78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c12478 - Browse repository at this point
Copy the full SHA 3c12478View commit details
Commits on May 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e85d346 - Browse repository at this point
Copy the full SHA e85d346View commit details -
rpc: version-alias latest event serde helpers
For consistency, define event::v0_37 and event::v0_38, aliasing the public definitions in event::latest.
Configuration menu - View commit details
-
Copy full SHA for a2015fb - Browse repository at this point
Copy the full SHA a2015fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa7d4b1 - Browse repository at this point
Copy the full SHA fa7d4b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2406f5a - Browse repository at this point
Copy the full SHA 2406f5aView commit details
Commits on May 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 77b5b63 - Browse repository at this point
Copy the full SHA 77b5b63View commit details -
Configuration menu - View commit details
-
Copy full SHA for c00766a - Browse repository at this point
Copy the full SHA c00766aView commit details
Commits on Jun 6, 2023
-
rpc: split ser/de helpers for Event
The Serialize impl needs to be implemented differently for 0.37 and 0.38 in order to emit old or new fields for NewBlock. The Deserialize impl, however, flexibly handles both formats to avoid introducing another dialect where most other helpers would be identical. This means that Event gets two different helpers for each protocol version: DeEvent for Deserialize and SerEvent for Serialize.
Configuration menu - View commit details
-
Copy full SHA for a4e3804 - Browse repository at this point
Copy the full SHA a4e3804View commit details -
rpc: 0.37 serialization for /broadcast_tx_commit
Provide v0_37::DialectResponse as a way to serialize responses in the 0.37 JSON format.
Configuration menu - View commit details
-
Copy full SHA for 569db8c - Browse repository at this point
Copy the full SHA 569db8cView commit details
Commits on Jun 7, 2023
-
rpc: Fix 0.38 websocket test by proper emulation
Use the exact protocol version to serialize test server responses as appropriate. No new variant is added to CompatMode, as that is a client-side setting and the client is able to cope with both versions dynamically.
Configuration menu - View commit details
-
Copy full SHA for 8d58a1d - Browse repository at this point
Copy the full SHA 8d58a1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d3dac8 - Browse repository at this point
Copy the full SHA 3d3dac8View commit details
Commits on Jun 12, 2023
-
No opinions have been expressed about any canonical way to serialize app hashes, so the explicit serializer helper should be there for now.
Configuration menu - View commit details
-
Copy full SHA for 51e47d0 - Browse repository at this point
Copy the full SHA 51e47d0View commit details
Commits on Jun 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3d05019 - Browse repository at this point
Copy the full SHA 3d05019View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18ccbcc - Browse repository at this point
Copy the full SHA 18ccbccView commit details -
Configuration menu - View commit details
-
Copy full SHA for e5f141b - Browse repository at this point
Copy the full SHA e5f141bView commit details