Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tendermint client does not support batched RPC requests #3

Open
tarcieri opened this issue Aug 1, 2019 · 3 comments
Open

Tendermint client does not support batched RPC requests #3

tarcieri opened this issue Aug 1, 2019 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed rpc

Comments

@tarcieri
Copy link
Contributor

tarcieri commented Aug 1, 2019

Copying/pasting this from tendermint/tmkms#301 as reported by @devashishdxt

Batched RPC requests are supported by tendermint since v0.31.6

tendermint/tendermint#3534

@thanethomson
Copy link
Contributor

Do we want similar semantics to how the Tendermint RPC client batch API works? See github.com/tendermint/tendermint/rpc/client/examples_test.go.

Essentially these semantics require that we:

  1. Use the client to create a batch (with similar methods as the client; will derive the target address from the client)
  2. Call methods on the batch that correspond to requests (e.g. broadcast_tx_async). This caches the calls in the batch.
  3. Call a send method that serializes the requests and returns an array of results, with each result corresponding to a cached request.

Once we agree on semantics, I can look at coding this in the coming weeks.

@tarcieri
Copy link
Contributor Author

@thanethomson I don't know the answers to your questions, but will say that the current client probably needs some refactoring in general, especially with the recent Rust developments in async/await support. I'm happy to field questions about that, and it seems like you may want to use futures to implement some of what you're describing.

@ebuchman ebuchman added the rpc label Jun 3, 2020
@brapse brapse added the help wanted Extra attention is needed label Jul 14, 2020
@thanethomson thanethomson added this to the v0.18 milestone Oct 6, 2020
greg-szabo added a commit that referenced this issue Oct 6, 2020
@greg-szabo greg-szabo mentioned this issue Oct 6, 2020
5 tasks
@romac romac reopened this Oct 11, 2020
@romac
Copy link
Member

romac commented Oct 11, 2020

This was likely closed by mistake because a commit in 592 contained #1.

@ebuchman ebuchman modified the milestones: v0.18, v0.19 Nov 22, 2020
@thanethomson thanethomson added the enhancement New feature or request label Mar 4, 2021
@thanethomson thanethomson removed this from the v0.20 milestone Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed rpc
Projects
None yet
Development

No branches or pull requests

5 participants