Skip to content

Commit

Permalink
Avoid enabling flex-error/eyre_tracer feature
Browse files Browse the repository at this point in the history
Don’t enable flex-error/eyre_tracer feature in crates which don’t use
eyre directly.  This allows customers depend on say tendermint crate
without having to pull in eyre crate.  This is useful because eyre
uses mutable static variables (specifically HOOK variable) which is
incompatible with some blockchain runtimes.
  • Loading branch information
mina86 committed Oct 13, 2023
1 parent bcc0b37 commit 9fac532
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 5 deletions.
4 changes: 4 additions & 0 deletions .changelog/unreleased/breaking-changes/eyre_tracer.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- Don’t enable `flex-error/eyre_tracer` feature in crates which don’t
use eyre directly. If you’re using eyre, and no other crate enables
it, you may need to enable that explicitly.
([\#1371](https://github.com/informalsystems/tendermint-rs/pull/1371))
2 changes: 1 addition & 1 deletion abci/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ path = "src/application/kvstore/main.rs"
required-features = [ "binary", "client", "kvstore-app" ]

[features]
default = ["flex-error/std", "flex-error/eyre_tracer"]
default = ["flex-error/std"]
client = []
echo-app = []
kvstore-app = []
Expand Down
2 changes: 1 addition & 1 deletion light-client-verifier/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ all-features = true
rustdoc-args = ["--cfg", "docsrs"]

[features]
default = ["rust-crypto", "flex-error/std", "flex-error/eyre_tracer"]
default = ["rust-crypto", "flex-error/std"]
rust-crypto = ["tendermint/rust-crypto"]

[dependencies]
Expand Down
2 changes: 1 addition & 1 deletion light-client/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ all-features = true
rustdoc-args = ["--cfg", "docsrs"]

[features]
default = ["rpc-client", "flex-error/std", "flex-error/eyre_tracer"]
default = ["rpc-client", "flex-error/std"]
rpc-client = ["tokio", "rust-crypto", "tendermint-rpc/http-client"]
rust-crypto = ["tendermint/rust-crypto", "tendermint-light-client-verifier/rust-crypto"]
secp256k1 = ["tendermint/secp256k1", "tendermint-rpc/secp256k1"]
Expand Down
2 changes: 1 addition & 1 deletion tendermint/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ ripemd = { version = "0.1.3", optional = true, default-features = false }

[features]
default = ["std", "rust-crypto"]
std = ["flex-error/std", "flex-error/eyre_tracer", "clock"]
std = ["flex-error/std", "clock"]
clock = ["time/std"]
secp256k1 = ["k256", "ripemd"]
rust-crypto = ["sha2", "ed25519-consensus"]
Expand Down
2 changes: 1 addition & 1 deletion tools/abci-test/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ description = """
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
flex-error = { version = "0.4.4", default-features = false, features = ["std", "eyre_tracer"] }
flex-error = { version = "0.4.4", default-features = false, features = ["std"] }
futures = "0.3"
structopt = "0.3"
tendermint = { version = "0.34.0", path = "../../tendermint" }
Expand Down

0 comments on commit 9fac532

Please sign in to comment.