Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to tendermint-rs v0.16 #243

Closed
ebuchman opened this issue Sep 20, 2020 · 1 comment · Fixed by #255
Closed

Update to tendermint-rs v0.16 #243

ebuchman opened this issue Sep 20, 2020 · 1 comment · Fixed by #255
Assignees
Milestone

Comments

@ebuchman
Copy link
Member

ebuchman commented Sep 20, 2020

Currently using tendermint-rs v0.15.

v0.16 includes minor changes, but two in particular that affect us:

  1. Removed the lite module (we need to change all references to point to the light_client crate now)
  2. Updated and removed some crypto dependencies (Replace signatory with ed25519-dalek and k256 crates tendermint-rs#522 (review))

Tendermint-rs v0.17 is a work in progress with lots of breaking changes from the proto stuff. We should upgrade to v0.16 first to deal with the breaking changes from (1) independently. Looks like this will be a bunch of work and will require some refactoring of the relayer crate

We need the changes from (2) to get signing working, ie. to merge the code from #242 into the relayer-cli

Could probably use help from @romac / @ancazamfir on this one

@ebuchman ebuchman added this to the v0.0.4 milestone Sep 20, 2020
@ebuchman ebuchman changed the title Update to tendermint v0.16 Update to tendermint-rs v0.16 Sep 20, 2020
@romac romac self-assigned this Sep 22, 2020
@romac
Copy link
Member

romac commented Sep 22, 2020

I will take care of this as part of #90.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants