ConnOpenInit from the CLI #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've refactored the code to focus only on having the MsgConnOpenInit CLI logic working properly. I've commented out the build and sign tx code for now. So the code is compiling and building now. But I still need to implement the DomainType logic and a few minor things to have the command executing properly (without the tx sign) which I'll do next. Once I have these then should be good to merge and and it's ready for review I'll ask people to review it. |
ancazamfir
reviewed
Sep 29, 2020
ancazamfir
approved these changes
Sep 30, 2020
4 tasks
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Initial implementation for the relayer tx command informalsystems#206 * Adding initial logic to support signing informalsystems#47 * Adding logic for auth tx * Implementing initial support to conn open init and tx informalsystems#206 * Changes: - Implemented logic for tx raw connection open init - Logic to build the message only using protobuf types - Got some signing logic but not validated - Still needs lots of refactoring and cleaning * update signing code to use k256 * Ignore .idea * Refactoring the ConnOpenInit logic. Disabling the build and sign tx code informalsystems#246 * Added logic for the conn init tx on relayer * Finished implementing MsgConnectionOpenInit. No signing implemented informalsystems#246 Co-authored-by: Andy Nogueira <me@andynogueira.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #206
Description
This is basically the tx signing work from #242 applied on top of this branch for use with ConnOpenInit.
It doesn't compile yet due to dependency issues which should be resolved by #243
Keeping this PR for the ConnOpenInit CLI logic only.
The build and sign transaction will be tracked and completed by #47 and when #243 is ready.
For contributor use:
docs/) and code commentsFiles changedin the Github PR explorer