Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mandatory flag --upgrade-height to hermes upgrade client #2300

Closed
5 tasks
plafer opened this issue Jun 14, 2022 · 1 comment · Fixed by #2357
Closed
5 tasks

Add mandatory flag --upgrade-height to hermes upgrade client #2300

plafer opened this issue Jun 14, 2022 · 1 comment · Fixed by #2357
Assignees
Labels
O: usability Objective: cause to improve the user experience (UX) and ease using the product
Milestone

Comments

@plafer
Copy link
Contributor

plafer commented Jun 14, 2022

Summary

Add --upgrade-height to hermes upgrade client and have hermes wait for that height until it submits the transaction.

Also document that hermes upgrade client must be run when the chain is halted if no --upgrade-height is included for the command to succeed.

Problem Definition

Currently hermes upgrade client needs to be run when the chain is halted for the command to succeed, and the error message is confusing when you don't.

We could add an optional flag --upgrade-height (or --halt-height?) and have hermes wait for that height until it submits the transaction. This would make it less confusing for users, as it is currently unclear that the command needs to be run when the chain is halted.

Acceptance Criteria

  • The --upgrade-height (or similar name) option is added to hermes upgrade client
  • Document that the command must be run when the chain is halted if --upgrade-height is not specified

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@plafer plafer mentioned this issue Jun 15, 2022
6 tasks
@plafer
Copy link
Contributor Author

plafer commented Jun 15, 2022

See #2304 for suggestion to force users to include an upgrade height with this command.

EDIT: We should really make this flag mandatory, see PR comment

@adizere adizere added this to the v1.0.0 milestone Jun 16, 2022
@adizere adizere added O: usability Objective: cause to improve the user experience (UX) and ease using the product P-medium labels Jun 16, 2022
@plafer plafer changed the title add an optional flag --upgrade-height to hermes upgrade client add mandatory flag --upgrade-height to hermes upgrade client Jun 16, 2022
@romac romac changed the title add mandatory flag --upgrade-height to hermes upgrade client Add mandatory flag --upgrade-height to hermes upgrade client Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
No open projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

4 participants