Fix client upgrade #2304
Merged
Fix client upgrade #2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plafer
requested review from
adizere,
romac,
seanchen1991,
ancazamfir and
mzabaluev
as code owners
5 tasks
adizere
reviewed
Jun 16, 2022
ancazamfir
reviewed
Jun 16, 2022
Co-authored-by: Adi Seredinschi <adi@informal.systems>
|
Can we add an integration test for client upgrade? Maybe in a different PR? |
|
I would vote for a different PR; I never looked into our integration framework, and I currently don't have the capacity to delve into it. But I agree that it is desirable; I'll create one and assign myself as an opportunity to learn it. |
6 tasks
adizere
approved these changes
Jun 17, 2022
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* use appropriate query height in upgrade * changelog * use application height in build_update_client * don't wait for target height * better error message * Update relayer/src/foreign_client.rs Co-authored-by: Adi Seredinschi <adi@informal.systems> * docstrings and var name change * use ibc::Height::decrement * add warning * query_latest_height call once Co-authored-by: Anca Zamfir <zamfiranca@gmail.com> Co-authored-by: Adi Seredinschi <adi@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2185
Description
I did not add a
query_chain_height()vsquery_latest_application_height(), as thequery_chain_height()would only be used in the special case of a client upgrade. Also, I now think it would be best if the cli for client upgrade forced the user to specify the chain upgrade height: it would be better UX IMO, and we wouldn't need to ever query the "chain height" (i.e. tendermint height). To be considered when dealing with #2300.PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.