Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass through an AppIniter func to be able to launch chains with different apps #1

Merged
merged 3 commits into from
May 5, 2022

Conversation

danwt
Copy link

@danwt danwt commented May 3, 2022

Issues

Partially tackles

Related to

Overview

There is a goal to split provider/consumer apps so that people can build from a minimal viable consumer chain. This PR is paired with another PR in cosmos/interchain-security. The two PR's together

  1. Split the app.go into two app.go's. One for parent and child.
  2. Modify ibc-go testing to be able to use two different app.go's.

Therefore this PR should be merged together with


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@danwt
Copy link
Author

danwt commented May 3, 2022

@jtremback - we said earlier to fork the testing parts of ibc-go into a separate repo and make changes there. That can still be the plan, but for now I have just changed informalsystems/ibc-go

@danwt danwt requested review from jtremback and sainoe May 3, 2022 18:05
@danwt danwt changed the title Danwt/support different app.go Pass through an AppIniter func to be able to launch chains with different apps May 3, 2022
@danwt danwt removed the request for review from jtremback May 4, 2022 08:05
@danwt danwt marked this pull request as ready for review May 4, 2022 10:12
Copy link

@sainoe sainoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work @danwt !

@sainoe sainoe merged commit 1f45da8 into interchain-security-2 May 5, 2022
@danwt danwt deleted the danwt/support-different-app.go branch May 9, 2022 11:15
sainoe pushed a commit that referenced this pull request Oct 10, 2024
…etupTest #1 (cosmos#6629)

* wip: refactoring tests to create chains in SetupSuite

* chore: refactoring memo test to use new setup fns

* chore: replace calls to setup chains and relayer with calls to get relayer and get channel

* chore: fix wiring in ThreeChainSetup

* chore: remove unused fn

* chore: add modification function based on chain inputs

* chore: update grandpa test with new structure

* chore: remove single chain methods

* chore: move upgrade tests into different files

* chore: fixing client tests

* chore: use paths associated with the test

* chore: add getter to fetch paths

* chore: fix client tests

* chore: fix misbehaviour test

* chore: fix misbehaviour test

* chore: mereg main

* chore: pr feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants