Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hermes ft-transfer: Verify open channel before sending message #961

Merged
merged 3 commits into from
May 20, 2021

Conversation

adizere
Copy link
Member

@adizere adizere commented May 19, 2021

Closes: #960

Description

Using a non-Open channel will result in an explicit error. For example, channel channel-3 on chain ibc-0 is in state Init.

$ hermes --json tx raw ft-transfer ibc-1 ibc-0 transfer channel-3 10000 -o 1000 -n 2

{"result":"the requested port/channel ('transfer'/'channel-3') on chain id 'ibc-0' is in state 'INIT'; expected 'open' state","status":"error"}


For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@adizere adizere changed the title Hermes fr-transfer: Verify open channel before sending message Hermes ft-transfer: Verify open channel before sending message May 19, 2021
@romac romac merged commit 58afa7f into master May 20, 2021
@romac romac deleted the adi/958_nonopen branch May 20, 2021 13:05
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
…ormalsystems#961)

* Channel open verification and bail unless Open

* Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hermes ft-transfer returns unhelpful error when using non-Open channel
2 participants