-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return error for uninitialized connection end or channel end query result #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancazamfir
changed the title
Return query error if uninitialized conn/chan
Return error for uninitialized connection end or channel end query result
May 11, 2021
romac
reviewed
May 11, 2021
romac
reviewed
May 11, 2021
romac
approved these changes
May 11, 2021
This was referenced May 24, 2021
Merged
ancazamfir
added a commit
that referenced
this pull request
May 26, 2021
* Added a worker for channel * Added query_connection_channels to the chain handle and runtime * Redo #923 to return `Uninitialized` when empty value bytes are returned * Changed the CLI to return error if connection/ channel does not exist * Allow entering the destination channel id in `hermes tx raw chan-open-try...` * Change `strategy` in config to be either `packets`(only relay packets) or `all` (relay from all events) * e2e CI changes Co-authored-by: Anca Zamfir <zamfiranca@gmail.com> Co-authored-by: Romain Ruetschi <romain@informal.systems> Co-authored-by: Adi Seredinschi <adi@informal.systems>
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
…sult (informalsystems#923) * Return query error if uninitialized conn/chan * Consistent output for query connection and channel comands * Apply suggestions from code review Co-authored-by: Romain Ruetschi <romain@informal.systems>
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Added a worker for channel * Added query_connection_channels to the chain handle and runtime * Redo informalsystems#923 to return `Uninitialized` when empty value bytes are returned * Changed the CLI to return error if connection/ channel does not exist * Allow entering the destination channel id in `hermes tx raw chan-open-try...` * Change `strategy` in config to be either `packets`(only relay packets) or `all` (relay from all events) * e2e CI changes Co-authored-by: Anca Zamfir <zamfiranca@gmail.com> Co-authored-by: Romain Ruetschi <romain@informal.systems> Co-authored-by: Adi Seredinschi <adi@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #875
Closes: #920
Description
query_channel()
andquery_connection()
to return error if the end is inUninitialized
StateUninitialized
channel the check for channel close was passing.For contributor use:
docs/
) and code comments.Files changed
in the Github PR explorer.