Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBT: Use modelator crate #724

Merged
merged 25 commits into from
Mar 23, 2021
Merged

MBT: Use modelator crate #724

merged 25 commits into from
Mar 23, 2021

Conversation

vitorenesduarte
Copy link
Contributor

@vitorenesduarte vitorenesduarte commented Mar 3, 2021

Closes: #761

Description

With this PR, we start using modelator, a model-based testing tool being developed at Informal. In particular:

  • the following files were removed as their functionality is now provided by modelator:
    • modules/tests/executor/modelator.rs
    • modules/tests/support/model_based/gen_tests.py
  • all static files in modules/tests/support/model_based/tests/ representing the tests generated by the model checkers are now generated on the fly (there are plans to cache them (see Add caching of model checking results modelator#27), which will speed up the developer experience when using modelator, but it won't improve CI times)

This PR currently relies on an unreleased version of modelator. This will be fixed by a follow-up PR (containing other improvements) once we do a proper release of modelator later this week.


For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@vitorenesduarte vitorenesduarte changed the base branch from vitor/mbt_match to master March 8, 2021 14:35
@vitorenesduarte vitorenesduarte changed the base branch from master to vitor/mbt_match March 8, 2021 14:35
Base automatically changed from vitor/mbt_match to master March 11, 2021 14:08
@vitorenesduarte vitorenesduarte marked this pull request as ready for review March 22, 2021 10:53
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

@romac
Copy link
Member

romac commented Mar 23, 2021

@vitorenesduarte Can you please update the changelog before we merge?

@vitorenesduarte
Copy link
Contributor Author

@vitorenesduarte Can you please update the changelog before we merge?

@romac Not sure it's a requirement for this kind of PRs, but I opened an issue and linked it in the changelog. Please check if this is okay.

@romac
Copy link
Member

romac commented Mar 23, 2021

Perfect, thanks!

@vitorenesduarte vitorenesduarte merged commit c2ba84b into master Mar 23, 2021
@vitorenesduarte vitorenesduarte deleted the vitor/modelator branch March 23, 2021 16:17
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
* Use modelador crate

* remove gen_tests.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MBT: Use modelator crate
2 participants